Added TestAndWait for CLI & runTestAndWait for Script #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkadlec
suggested changes
Mar 17, 2022
tkadlec
reviewed
Apr 5, 2022
lib/webpagetest.js
Outdated
| @@ -531,199 +537,15 @@ function runTest(what, options, callback) { | |||
| } | |||
|
|
|||
| function runTestAndWait(what, options, callback) { | |||
| delete options.pollResults; | |||
| delete options.pollResults, options.timeout; | |||
| delete options.timeout; | |||
There was a problem hiding this comment.
This appears to be a duplicate line.
tkadlec
reviewed
Apr 5, 2022
lib/webpagetest.js
Outdated
| @@ -531,199 +537,15 @@ function runTest(what, options, callback) { | |||
| } | |||
|
|
|||
| function runTestAndWait(what, options, callback) { | |||
| delete options.pollResults; | |||
| delete options.pollResults, options.timeout; | |||
There was a problem hiding this comment.
Hmm...do we want to delete timeout? Like...if they pass a timeout, then runTest would use that and it lets them still put a time limit on runTestAndWait, right? Seems handy to keep it around?
There was a problem hiding this comment.
oops sorry left that one unknowingly, Cool I will let users to pass the timeout. Well at first I thought if we are creating a dedicated function for run test and wait then it should totally wait 🙂.
There was a problem hiding this comment.
Yeah...I do like us not requiring timeout here at all, but I think it's nice to be able to override if necessary.
tkadlec
suggested changes
Apr 5, 2022
tkadlec
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added testAndWait (CLI) & runTestAndWait method for Wrapper. A bit of a hacky way and can definitely be improved in future. It basically runs the test and waits for the whole execution process (Has an inbuilt pollResults param whether a user provides it or not and deletes the timeout param if provided by the user), then returns the full data object