Use console reporter's totals summary for compact reporter #2554
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #2554 +/- ##
==========================================
+ Coverage 91.15% 91.30% +0.15%
==========================================
Files 185 185
Lines 7614 7596 -18
==========================================
- Hits 6940 6935 -5
+ Misses 674 661 -13 |
| std::size_t row, | ||
| std::ostream& stream, | ||
| ColourImpl& colour ) { | ||
| for ( auto col : cols ) { |
There was a problem hiding this comment.
Does this need to be a copy? From a quick glance I would say no, the code does not modify the SummaryColumn here.
(I know it is like this in the original code, but I am looking through it again here and hoo boy, it is a mess)
|
Looks good, with two drive-by fixes since you are already touching that code. Honestly you can ignore them if you want 🤷 |
|
Sure, no problem. I did a refactoring pass as a fixup commit, will squash once approved. Speaking of messes, I originally planned to do a larger refactoring of how |
|
Yeah, shouldfail/mayfail is also a "fun" mess. It is what happens when the code is evolved over time for 10+ years 😃 |
This changes the compact reporter's summary of test run totals to use the same format as the console reporter. This means that while output is no longer on a single line (two instead), it now includes totals for `failedButOk` test cases and assertions, which were previously missing.
psalz
force-pushed
the
improve-compact-shouldfail-reporting
branch
from
0dea420 to
2e66a84
Compare
This changes the compact reporter's summary of test run totals to use the same format as the console reporter. This means that while output is no longer on a single line (two instead), it now includes totals for
failedButOktest cases and assertions, which were previously missing.Fixes #878.