Fix filename as tag bug #2393
Merged
Fix filename as tag bug #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a test file isn't provided with "/" in the path, the filename isn't registered as a tag. Fixing by providing a conditon for this edge case. Closes catchorg#2328
Codecov Report
@@ Coverage Diff @@
## v2.x #2393 +/- ##
==========================================
- Coverage 90.10% 90.08% -0.02%
==========================================
Files 113 113
Lines 5038 5040 +2
==========================================
+ Hits 4539 4540 +1
- Misses 499 500 +1 |
|
Thanks. As the code currently is, it is pretty much impossible to write a test -- the function that trims out the filename would have to be split into its own header, and then the tests could be written. Given that this change is only relevant to v2 branch, I don't think this is worth the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a test file isn't provided with "/" in the path, the filename isn't registered as a tag.
Fixing by providing a condition for this edge case.
This is the first time I'm contributing to this project (trying to learn c++). I wasn't sure where to add a test for this change, so would appreciated if someone could point to place.
GitHub Issues
This PR fixes #2328