-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AllTrue, AnyTrue, NoneTrue generic range matchers #2319
Add AllTrue, AnyTrue, NoneTrue generic range matchers #2319
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #2319 +/- ##
==========================================
+ Coverage 91.49% 91.52% +0.03%
==========================================
Files 181 182 +1
Lines 7519 7549 +30
==========================================
+ Hits 6879 6909 +30
Misses 640 640 |
Closes #2136. |
If I could rebase this and include the (All|Any|None)True matchers in the now-existing src/catch2/matchers/catch_matchers_quantifiers.hpp(since 57c8036), would that work? Or should they be implemented differently? |
Actually, clearly I misread the diff - the only rebase needed here was in .gitignore and the approval test counts: https://github.com/johnbeard/Catch2/tree/matchers_all_any_none_true Is there anything else I can do here to drive this forward? Merging these matchers would be useful to me. |
@johnbeard If you split out the test refactoring to separate PR and then a separate PR for the new functionality, I will review both. |
I split out the test refactoring to #2386. I'll rebase this PR once the other one is merged. |
5f81cf4
to
1b9fc4b
Compare
cf4793c
to
96630f0
Compare
Description
This PR adds
AllTrue
,AnyTrue
,NoneTrue
generic range matchers, which match a range if all, any, or none of the elements in a range aretrue
, respectively.GitHub Issues
Addresses issue #2109.