Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgconfig: Add missing entries #2284

Merged
merged 1 commit into from
Sep 10, 2021
Merged

pkgconfig: Add missing entries #2284

merged 1 commit into from
Sep 10, 2021

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Sep 8, 2021

This adds prefix, exec_prefix and libdir fields

This adds prefix, exec_prefix and libdir fields
@Biswa96
Copy link
Contributor Author

Biswa96 commented Sep 8, 2021

The prefix and exec_prefix are also needed in devel branch. Should I create another PR for devel branch?

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #2284 (0f11e85) into v2.x (4b97802) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v2.x    #2284   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         113      113           
  Lines        5035     5035           
=======================================
  Hits         4536     4536           
  Misses        499      499           

@horenmar
Copy link
Member

Thanks, I don't actually use pkg-config, so bugs there might be around for a long time.

The prefix and exec_prefix are also needed in devel branch. Should I create another PR for devel branch?

Yes.

@horenmar horenmar merged commit 85c9544 into catchorg:v2.x Sep 10, 2021
@Biswa96 Biswa96 deleted the v2.x branch September 10, 2021 18:10
@horenmar horenmar added the Building and Packaging Issues affecting build/packaging scripts and utilities label Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants