Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include <iterator> for using std::back_inserter #2231

Closed
wants to merge 1 commit into from

Conversation

vincent-hui
Copy link

@vincent-hui vincent-hui commented May 11, 2021

<iterator> should be included explicitly for using std::back_inserter. My test code cannot be compiled without including <iterator> on my platform.

Sorry, I do not know where #include <iterator> should be added except in this header file. Would you mind telling me where #include <iterator> should be added if the single-include catch.hpp should not be changed by pull requests?

Description

GitHub Issues

<iterator> should be included explicitly for using std::back_inserter. My test code cannot be compiled without including <iterator> on my platform.
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #2231 (5474e83) into v2.x (5c88067) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v2.x    #2231   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files         139      139           
  Lines        5705     5705           
=======================================
  Hits         5065     5065           
  Misses        640      640           

@horenmar
Copy link
Member

Done in the proper place in the referencing commit.

@horenmar horenmar closed this May 21, 2021
@vincent-hui
Copy link
Author

Thank you very much.

When will new https://github.com/catchorg/Catch2/blob/v2.x/single_include/catch2/catch.hpp be generated?

@horenmar
Copy link
Member

I don't want to promise anything, but for now you could generate it yourself with scripts/generateSingleHeader.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants