Support template test cases in ParseAndAddCatchTests #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change regex to allow parentheses inside the test macro for a type list * Append a wildcard to the CTestName if the test case is a template * Also change the regular expression so parentheses are allowed in names (fixes catchorg#1848)
Codecov Report
@@ Coverage Diff @@
## master #2031 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 138 138
Lines 5651 5651
=======================================
Hits 5015 5015
Misses 636 636 |
I am going to take you on your word with that, because that regex is too much. Anyway, thanks. |
horenmar
added
the
Extras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes ParseAndAddCatchTests.cmake silently ignores test that contains right parenthesis #1848)
Description
GitHub Issues