Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide std::exception_ptr and friends if exceptions disabled #1950

Merged
merged 1 commit into from Jun 12, 2020
Merged

Hide std::exception_ptr and friends if exceptions disabled #1950

merged 1 commit into from Jun 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2020

Description

Some compilers, e.g. the Green Hills C++ compiler, react badly to the
appearance of std::exception_ptr, std::current_exception,
std::rethrow_exception and std::uncaught_exception(s). To allow usage of
Catch2 with these compilers when exceptions are disabled, hide the usage
of std::exception_ptr etc. when compiling with
CATCH_CONFIG_DISABLE_EXCEPTIONS.

Some compilers, e.g. the Green Hills C++ compiler, react badly to the
appearance of std::exception_ptr, std::current_exception,
std::rethrow_exception and std::uncaught_exception(s). To allow usage of
Catch2 with these compilers when exceptions are disabled, hide the usage
of std::exception_ptr etc. when compiling with
CATCH_CONFIG_DISABLE_EXCEPTIONS.
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #1950 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1950   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files         138      138           
  Lines        5616     5616           
=======================================
  Hits         4976     4976           
  Misses        640      640           

@horenmar
Copy link
Member

I would prefer if all platforms provided stubbed out exception-related functions, but I do support -fno-except. Oh well.

Thanks.

@horenmar horenmar merged commit 0614a4a into catchorg:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant