Fix issue #1809. #1815
Merged
Fix issue #1809. #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did most of my work in Godbolt, hopefully all the CI passes. |
|
Looks like Travis is having some issues downloading packages. |
Codecov Report
@@ Coverage Diff @@
## master #1815 +/- ##
==========================================
+ Coverage 86.29% 86.31% +0.03%
==========================================
Files 131 131
Lines 3894 3887 -7
==========================================
- Hits 3360 3355 -5
+ Misses 534 532 -2 |
|
Thanks, I moved the tests around a little bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SingleValueGenerator CTor clash. Correct some misuses of move when forward was needed. Correct some missing universal references in method parameter lists. Add IntrospectiveTest to verify fix for issue #1809.
Description
SingleValueGenerator had 2 clashing CTors thanks to the semantic differences in universal references and rvalue references when used in templates as parameters.
GitHub Issues
Closes #1809