Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified benchmark output with --benchmark-no-analysis #1768

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Simplified benchmark output with --benchmark-no-analysis #1768

merged 1 commit into from
Oct 8, 2019

Conversation

RT2Code
Copy link
Contributor

@RT2Code RT2Code commented Oct 7, 2019 •
edited
Loading

Removed unused informations from benchmarks output when --benchmark-no-analysis flag is used to improve readability.

@RT2Code
Simplified benchmark output with --benchmark-no-analysis
2331249 
Removed unused informations from benchmarks output when the --benchmark-no-analysis flag is used, making the results easier to read.
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #1768 into master will decrease coverage by 0.09%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
- Coverage    87.7%   87.61%   -0.09%     
==========================================
  Files         136      136              
  Lines        5357     5368      +11     
==========================================
+ Hits         4698     4703       +5     
- Misses        659      665       +6

@RT2Code
Copy link
Contributor Author

RT2Code commented Oct 7, 2019

Before :

...............................................................................

benchmark name                                  samples       iterations    estimated
                                                mean          low mean      high mean
                                                std dev       low std dev   high std dev
-------------------------------------------------------------------------------
1 component creation                                      100             1    64.1466 ms
                                                   234.586 us    234.586 us    234.586 us
                                                         0 us          0 us          0 us

3 components creation                                     100             1    83.6913 ms
                                                   315.606 us    315.606 us    315.606 us
                                                         0 us          0 us          0 us

10 components creation                                    100             1    128.337 ms
                                                   663.002 us    663.002 us    663.002 us
                                                         0 us          0 us          0 us

After :

...............................................................................

benchmark name                            samples    iterations          mean
-------------------------------------------------------------------------------
1 component creation                           100             1    234.586 us
3 components creation                          100             1    315.606 us
10 components creation                         100             1    663.002 us

@horenmar
Copy link
Member

horenmar commented Oct 8, 2019

Thanks, the changes look good.

@horenmar horenmar merged commit 75200e1 into catchorg:master Oct 8, 2019
@horenmar horenmar added the Tweak label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RT2Code @horenmar