hexEscapeChar: restore stream #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ostream passed as reference to `hexEscapeChar` is manipulated and its original state not restored. This fixes it. Seen via coverity in a downstream project.
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
=========================================
- Coverage 80.42% 80.4% -0.02%
=========================================
Files 121 121
Lines 3421 3428 +7
=========================================
+ Hits 2751 2756 +5
- Misses 670 672 +2 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
=========================================
- Coverage 80.42% 80.4% -0.02%
=========================================
Files 121 121
Lines 3421 3428 +7
=========================================
+ Hits 2751 2756 +5
- Misses 670 672 +2 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ostream passed as reference to
hexEscapeCharis manipulated and its original state not restored. This is an unexpected side effect and now fixed.Seen via coverity in a downstream project.