Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#145 Moodle 4.3 - Deprecated get_all_user_name_fields() #146

Conversation

joshwillcock
Copy link
Contributor

This checks if the new function is available and uses it, otherwise it will use the old one keeping it backwards compatible.

@danmarsden
Copy link
Member

Thanks Josh - we're more of a fan of branching new versions than adding these sorts of checks in place - feel free to update it to use the new api and I'll just create a new branch in the repo here as needed otherwise I'll try to remember to come back to it!

@joshwillcock
Copy link
Contributor Author

Hey @danmarsden,
I've pushed the 4.3 version, but it'll need to go to 403 & not 400...
Hope it helps.

@danmarsden
Copy link
Member

just looking back at this - get_all_user_name_fields was deprecated in 3.11, so it should be safe going on MOODLE_400_STABLE - it's just that it was removed completely in 4.3

@danmarsden
Copy link
Member

I've manually cherry-picked this across into the MOODLE_400_STABLE branch as it works in 4.0 and higher.

@danmarsden danmarsden closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants