Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W&B: add artifacts support and fix logging steps #1309

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

AyushExel
Copy link
Contributor

Pull Request FAQ

Description

This PR:

  • Adds support for artifacts
  • Uses global sample step for logging
  • Removes explicit wandb.finish() call from logger to facilitate logging artifacts after training is finished.

Related Issue

#1290 (comment)

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest and minimal requirements?
  • Have you checked XLA integration with single and multiple processes?

catalyst/loggers/wandb.py Outdated Show resolved Hide resolved
catalyst/loggers/wandb.py Outdated Show resolved Hide resolved
@Scitator Scitator merged commit bd3a0d7 into catalyst-team:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants