Add TREC Covid Reranking Task #95
Conversation
pygaggle/rerank/transformer.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| PreTrainedTokenizer, | |||
| T5ForConditionalGeneration) | |||
| import torch | |||
|
|
|||
| import logging | |||
| if i + seg_size >= len(sentences): | ||
| end_idx += i/stride + 1 | ||
| doc_end_indexes.append(int(end_idx)) | ||
| break | ||
| return SegmentGroup(segmented_doc, doc_end_indexes) | ||
|
|
||
| def aggregate(self, documents: List[Text], segments_group: SegmentGroup, method: str = "max") -> List[Text]: |
There was a problem hiding this comment.
Add a short docstring to each method and one for the file describing what it does in general?
There was a problem hiding this comment.
Added one for the classes. Is that good enough?
There was a problem hiding this comment.
It is good to have a docstring for each method, even if it is only one or two sentences.
There was a problem hiding this comment.
I added for the methods and classes. I guess my question should have been whether I should add a docstring for the file?
There was a problem hiding this comment.
Sorry for the late reply. Ideally, there should be a docstring for the file, but I think it is fine docstrings for methods and classes only.
|
|
||
| def main(): | ||
| apb = ArgumentParserBuilder() | ||
| apb.add_opts(opt('--task', |
There was a problem hiding this comment.
Add descriptions for the parameters?
There was a problem hiding this comment.
Just to be clear, do you mean setting the help string for each or just describing the parameters as comments in the code?
|
Hey @justinborromeo, let us know when this is ready for another review? |
|
Ready for review! |
|
@justinborromeo do you have merge permissions? |
No :( |
Command:
Qrels file: qrels-covid_d5_j4.5-5.txt
Input Runfile: expanded.anserini.final-r5fusion1.txt
Queries: topics-covid-round5.xml
trec_eval output: https://gist.github.com/justinborromeo/cb6cff577c926d47a78ba9170add5dd9
The scores shown in the trec_eval output seem a little bit low. I'll add documentation after this has been reviewed.