Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update transformers==2.10.0 to transformers==4.0.0rc1 #118

Merged
merged 1 commit into from
Nov 24, 2020
Merged

update transformers==2.10.0 to transformers==4.0.0rc1 #118

merged 1 commit into from
Nov 24, 2020

Conversation

MXueguang
Copy link
Member

for Issue #107

fix transformers v3.x & v4.x conflicts based on https://github.com/huggingface/transformers/releases/tag/v4.0.0-rc-1

fixed:

  • prepare_inputs_for_generation output types
  • tokenizer args, e.g. padding, truncate
  • model forward return_dict
  • requirements

replicated

  • msmarco-passage-subset experiments on MonoBert & MonoT5-base

rodrigonogueira4
rodrigonogueira4 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

ronakice
ronakice approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@ronakice ronakice merged commit b235fae into castorini:master Nov 24, 2020
@MXueguang MXueguang mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronakice ronakice ronakice approved these changes

@rodrigonogueira4 rodrigonogueira4 rodrigonogueira4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MXueguang @rodrigonogueira4 @ronakice