Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor controller_test #195

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

pijusn-cast
Copy link
Contributor

I wanted to refactor this test outside my primary task in order to isolate changes and avoid huge diffs. I want this test to:

  • easily accept samples having the same kind but different GV (currently, we don't have such sample as we don't support them yet)
  • support using unstructured.Unstructured runtime type (which is why data is compared using JSON helpers rather than plain bytes).

Also, note:

  • To maintain consistency, updated other test cases to use the same pattern to compare the serialised JSONs.
  • Added TypeMeta values everywhere to be more consistent as we start caring about these for some types.

@pijusn-cast pijusn-cast changed the title feat: refactor controller_test chore: refactor controller_test Oct 22, 2024
@pijusn-cast pijusn-cast merged commit 4dc6352 into main Oct 23, 2024
2 checks passed
@pijusn-cast pijusn-cast deleted the pijusn/refactor-controller-test branch October 23, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants