Fix and add tests for iOS 15 devices #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff appears fine to me, but definitely worth having @NickEntin 👀 on this one. The CI seems like does not have xcode 13.2 though @luispadron ? |
|
@jhneves Thanks for checking! Yeah I'm not entirely sure how to use new Xcode with GitHub actions, I'll defer to @NickEntin here 🙏🏼 Edit: Updated to use |
luispadron
force-pushed
the
lpadron/fix-ios15-crash
branch
from
010ab5b to
e1a6803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
fishhook.ccode in the repository had started crashing for iOS 15 devices. I copied the contents from the.cfile from the fix in this PR: facebook/fishhook#87I also attempted to add tests for iOS 15, not sure if I added them correctly to CI but I generated the snapshots and tested locally with iOS 15.2 iPhone 13 Pro.