Adds no-exit-message Setting and [exit-message] attribute

[ArchieAtkinson]

This adds both the no-exit-message setting and the [exit-message] attribute. Current behaviour is [exit-message] overrides both set no-exit-message and [no-exit-message].

Idea from #2566.

I would like feedback on whether I need to add anything to the documents and whether any test cases are missing.

[casey]

Looks good!

• I think there is an additional test case, just a plain recipe with the [no-exit-message] attribute with no setting.
• • [exit-message] and [no-exit-message] on the same recipe should produce an error, and this should also have a test

[ArchieAtkinson]

All comments done.

Added additional suggested tests and moved all tests to no_exit_messsage.rs.

Also added a commit to refactor the other tests in no_exit_messsage.rs to Test::new() if that is suitable for this PR.

Let me know if there is anything else that needs changing.

[casey]

Looks good! I merged latest master in, and changed the order of tests so they're easier to review.

Only one thing left, having [exit-message] and [no-exit-message] on the same recipe should be a compiler error.

You can see an example with the working-directory attribute and no-cd attribute in parser.rs:

    let working_directory = attributes.contains(AttributeDiscriminant::WorkingDirectory);

    if working_directory && attributes.contains(AttributeDiscriminant::NoCd) {
      return Err(
        name.error(CompileErrorKind::NoCdAndWorkingDirectoryAttribute {
          recipe: name.lexeme(),
        }),
      );
    }

You'll have to create a new CompileErrorKind variant.

[ArchieAtkinson]

@casey added the requested changes, thank you for reviewing and for the feedback!

[casey]

LGTM!