Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Listings UI #84

Merged
merged 10 commits into from
Apr 19, 2017
Merged

Listings UI #84

merged 10 commits into from
Apr 19, 2017

Conversation

casey-chow
Copy link
Owner

  1. Only one listing can be open at a time.
  2. Expands listings out a bit and animates them.
    new-listing-expand

@casey-chow casey-chow changed the title [WIP] Listings UI Listings UI Apr 19, 2017
@casey-chow casey-chow requested a review from ewilden April 19, 2017 21:03
@ewilden
Copy link
Collaborator

ewilden commented Apr 19, 2017

Listing expand animation is slightly jerky. You've probably already looked into this but: mui/material-ui#3241 features some discussion on animating expansion of Cards.
Also: mui/material-ui#3392

@casey-chow casey-chow requested a review from awonnacott April 19, 2017 21:14
@casey-chow
Copy link
Owner Author

Listing expand animation is slightly jerky. You've probably already looked into this but: mui/material-ui#3241 features some discussion on animating expansion of Cards.

It's an improvement on our existing animation (or lack thereof)--if you feel strongly about the animation, I recommend opening an issue for the future.

@casey-chow casey-chow merged commit eece7c8 into master Apr 19, 2017
@awonnacott awonnacott deleted the casey/listings-ui branch April 20, 2017 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants