Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated has_key #132

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Remove deprecated has_key #132

merged 2 commits into from
Jan 31, 2018

Conversation

tammojan
Copy link
Contributor

Remove some deprecated calls to has_key (removed in python 3.x), in favor of the pythonic a in b form. Thanks @jamiefarnes for spotting this in casacore/casacore#692

@pep8speaks
Copy link

pep8speaks commented Jan 31, 2018 •
edited
Loading

Hello @tammojan! Thanks for updating the PR.

Line 458:80: E501 line too long (82 > 79 characters)
Line 484:80: E501 line too long (86 > 79 characters)
Line 797:14: E127 continuation line over-indented for visual indent

Comment last updated on January 31, 2018 at 16:15 Hours UTC

@tammojan tammojan merged commit af92cc8 into casacore:master Jan 31, 2018
@tammojan tammojan deleted the nohaskey branch January 31, 2018 20:48
@gijzelaerr gijzelaerr added this to the 2.3 milestone Oct 30, 2018
@sjperkins sjperkins mentioned this pull request Oct 30, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tammojan @pep8speaks @gijzelaerr