Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only work with prefixed jobs #23

Merged
merged 4 commits into from
Dec 3, 2020
Merged

chore: only work with prefixed jobs #23

merged 4 commits into from
Dec 3, 2020

Conversation

livioso
Copy link
Contributor

@livioso livioso commented Dec 2, 2020

This is most likely a temporary "workaround", the proper solution would probably be to use namespaces. Right now, AWS IoT Job Namespaces are in public preview (and unavailable for us).

This fixes the issue that Upparat has a monopoly on AWS IoT Job API, i.e. allows adding other services to also use AWS IoT Jobs on the same thing.

note: this is most likely a temporary "workaround",
the proper solution would probably be to use namespaces.

Right now, AWS IoT Job Namespaces are in public preview.

This fixes the issue that Upparat has a monopoly on AWS IoT Job API,
i.e. allows adding other services to also use AWS IoT Jobs on the same
thing.
@livioso livioso marked this pull request as ready for review December 2, 2020 12:48
@livioso livioso requested a review from aeby December 2, 2020 12:48
Copy link
Contributor

@aeby aeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/config/config_test.py Outdated Show resolved Hide resolved
@livioso livioso merged commit 38bc1eb into master Dec 3, 2020
@livioso livioso deleted the chore/prefix branch December 3, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants