Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Haaaanger on Download #20

Merged
merged 4 commits into from
Oct 22, 2020
Merged

Fix Haaaanger on Download #20

merged 4 commits into from
Oct 22, 2020

Conversation

livioso
Copy link
Contributor

@livioso livioso commented Oct 22, 2020 •
edited
Loading

  • Bugfix: Make sure we restart the job if we have unhandled exceptions.
  • Improvement: Retry w/ backofff on ConnectionResetError.

closes #19

@livioso livioso marked this pull request as ready for review October 22, 2020 13:01
@livioso livioso requested a review from aeby October 22, 2020 13:01
@livioso livioso self-assigned this Oct 22, 2020
@livioso livioso added the bug Something isn't working label Oct 22, 2020
aeby
aeby approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@aeby aeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@livioso livioso merged commit 72d2f7b into master Oct 22, 2020
@livioso livioso deleted the fix/haaaaanger-in-download-on-error branch October 22, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeby aeby aeby approved these changes

Assignees

@livioso livioso

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upparat stuck in download state
2 participants
@livioso @aeby