Add a docker-compose.yml file for development purposes #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I though that it could be convenient to allow contributors the option to work with a
docker-compose.yml
file. Doing so ensures the developer works with the same node version as the one used in production.No more yarn needed on the developer machine, just
docker exec -ti noether sh
to get a shell access and easily run tests, etc...I also updated the
.dockerignore
file to ignore thedocker-compose.yml
that will not be needed in the Docker image, as well as other files and dirs that could also be added.Regarding the compose file, we could also name it
docker-compose.dev.yml
ordocker-compose-dev.yml
if you think the current name could lead to confusion for standard users, but it would mean a more verbose command to bootstrap the contributor environment:docker-compose -f docker-compose.dev.yml up -d
instead of the simpledocker-compose up -d
.Please tell me if you have any question or you would like to see more improvement to the work I've done. Thanks!