Upgrade runtime to latest LTS (22) #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12857276852Details
💛 - Coveralls |
nevendyulgerov
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code changes to set the web app to run using the latest node runtime LTS (v22). No regressions were identified.
Important
For the reviewer/tester: It is important for sanity's sake to remove all the local node_modules before installation.
For context: I got caught up in a rabbit hole with a third-level dependency (@ensdomains/ens-contract) using an old version of hardhat that set the engine to maximum node v18. It led me to checkout cartesi/staking-pool make upgrades, and install that locally into my staking project. That allowed the package manager to pass the engine checks and enabled the update in the
yarn.lock, but it would cost a redeploy of contracts as there was a change in the imports ofensdomains/ens-contractsfor a solidity contract (that is an undesirable outcome). After checking these deps releases, I rolled back the local install, and it was now working as the Hardhat in ouryarn.lockhad upgraded to its latest version. As these dependencies use the caret symbol (^), the problem was solved.