Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade wallet packages #180

Merged
merged 12 commits into from
Jan 19, 2025
Merged

Conversation

brunomenezes
Copy link
Collaborator

@brunomenezes brunomenezes commented Jan 14, 2025

Summary

Code changes to accommodate the new web3-onboard core and the latest version of the wallet modules.
Tested locally and also using deployed version inside the safe.global web App.

Changes:

  • Upgrade web3-onboard core to its latest version
  • Upgrade gnosis (a.k.a safe-global), injected-wallets, walletconnect and coinbase's module.
  • Add two new modules required by the new gnosis version. @safe-global/safe-apps-provider and @safe-global/safe-apps-sdk.
  • Upgraded typescript v4 to v5. Also, I fixed all typing problems highlighted by the linter during the build phase.
  • Update the configurations for the walletconnect. This includes removing the version property; the latest wallet connect module version dropped support for WC version 1 and included the new dappUrl option property.
  • Update the testing library and include new globals, TextEncoder and TextDecoder, in the Jest setup.
  • Storybook:
    • Add the new webpack mappings and add-ons for the storybook to work under the Staking configuration.
    • Include the new webpack mappings and add-ons for the storybook to work under the @packages/ui. A new npm script for build-storybook was added to ensure it works on every CI build after calling the turborepo task with the same name.

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 2:36am

Copy link

github-actions bot commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12796851505

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 77.578%

Totals Coverage Status
Change from base Build 12756541872: 0.03%
Covered Lines: 340
Relevant Lines: 403

💛 - Coveralls

@brunomenezes brunomenezes self-assigned this Jan 15, 2025
@brunomenezes brunomenezes linked an issue Jan 15, 2025 that may be closed by this pull request
3 tasks
@brunomenezes brunomenezes merged commit 5bdd6b8 into main Jan 19, 2025
8 of 9 checks passed
@brunomenezes brunomenezes deleted the chore/upgrade-wallet-packages branch January 19, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore - Update wallet modules
2 participants