-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes (new lattice, measurement fixes, more) #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffreyer
changed the title
[Breaking ]Fixes
Breaking changes (new lattice, measurement fixes, more)
May 16, 2022
ffreyer
commented
May 16, 2022
currently named DQMCHelpers
fast Bravais, slow Basis this lines up better with directional iterators
This was referenced Oct 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goals of this pr are now:
featuredata parity with LatticePhysics (maybe allowing direct conversion back and forth?)enum,symbolsor stringsfor type stability and startup performancehopping_directions maybenot worth optimizingdirections(iter, lattice)
should maybe existFourier transform for measurementsexpensive during simulation, moved elsewhere post simulationAnd since the lattice changes will most likely be breaking I'll get some other breaking stuff done.
General changes/TODO:
EachLocalQuadByDistance
a bitpotentially fix error consistency vs ED(still ~$2\Delta\tau^2$), maybe use jackknife)Use StableRNGs for tests (or use random seeds where applicable)This doesn't really work for us because most of our random's happen inside the libraryRandom.seed!
in tests (remove DQMC checks vs hardcoded values, allow larger errors, don't check random confs)JLD2.load()
at the start instead of loading data piece by pieceremovedoesn't need to happen hereflv
andmodel
from kernel functions. Sincemc
is passed this information is available and usually doesn't do much but bloat the call signaturenearest_neighbor_count
andhopping_directions
directions