Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes startdate and enddate comments #285

Merged
merged 1 commit into from
Jan 24, 2016
Merged

Conversation

Spaxe
Copy link
Contributor

@Spaxe Spaxe commented Jan 22, 2016

Use YYYY-MM-DD instead of "YYYY-MM-DD", which offends tools/check.py

Use YYYY-MM-DD instead of "YYYY-MM-DD", which offends `tools/check.py`
@wking
Copy link
Contributor

wking commented Jan 22, 2016

On Thu, Jan 21, 2016 at 07:06:46PM -0800, Xavier Ho wrote:

Use YYYY-MM-DD instead of "YYYY-MM-DD", which offends
tools/check.py

I'm pretty sure the quotes are intended for:

YYYY-MM-DD

although that isn't consistently applied (e.g. the instructor example
just dives in with the YAML ‘[…]’ which includes double-quotes). The
simple fix would be to pick a safer character like a backtick (`), use
that consistently, and explain it in the README 1. The more robust
solution would be to remove the comments here (just stop after
‘FIXME’) and to document each setting in the README (where you can use
Markdown backtics to get literal examples rendered differently without
visible characters delimiting them).

@gvwilson
Copy link
Contributor

Or modify the comment lines to say:

startdate: FIXME # use YYYY-MM-DD format like 2015-01-01 (no quotes around the date)

??

@wking
Copy link
Contributor

wking commented Jan 22, 2016

On Fri, Jan 22, 2016 at 02:33:36AM -0800, Greg Wilson wrote:

Or modify the comment lines to say:

startdate: FIXME # use YYYY-MM-DD format like 2015-01-01 (no quotes around the date)

And repeat for every entry where we currently use quote delimiters
that should not be included in the final value? I'd rather just use
backticks and explain not to copy backticks in the README.

rgaiacs added a commit that referenced this pull request Jan 24, 2016
Fixes `startdate` and `enddate` comments
@rgaiacs rgaiacs merged commit b62d6ce into carpentries:gh-pages Jan 24, 2016
fmichonneau pushed a commit that referenced this pull request Jun 20, 2018
Move CODE_OF_CONDUCT.md to boilerplate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants