Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update z-index for bottom-nav #36

Merged
merged 3 commits into from
May 11, 2022
Merged

update z-index for bottom-nav #36

merged 3 commits into from
May 11, 2022

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented May 10, 2022

This will make sure that the dropdown menus appear on top of the sidebar
on xxl screens.

It turns out that it was a z-index issue, but not of the .dropdown-menu
class. It was the z-index of the .bottom-nav class (and why it's called bottom
nav is because in the header the top nav is for language and instructor view)
that I needed to set to z-index: 3.

The reason why this happened is because the z-index depends on the position
of the element. In this case, the position was relative to the parent element
, which was the nav.bottom-nav, and this was set to have a z-index of 2 in
the document, but the sidebar in div.container > div.sidebar-col > div.sidebar also has a z-index of 2, which means that since it comes after the
nav.bottom-nav, it still appears closer to the user.

https://css-tricks.com/almanac/properties/z/z-index/

This will address #35

zkamvar and others added 3 commits May 10, 2022 16:45
This will make sure that the dropdown menus appear on top of the sidebar
on xxl screens.

This will address #35
@zkamvar zkamvar merged commit e9f5f87 into main May 11, 2022
@zkamvar zkamvar deleted the fix-navbar-z branch May 11, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants