Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Put the fury camera setup into a function #76

Merged
merged 1 commit into from
Mar 24, 2021
Merged

ENH: Put the fury camera setup into a function #76

merged 1 commit into from
Mar 24, 2021

Conversation

jhlegarreta
Copy link
Contributor

Put the furycamera setup into a function.

Allows to reuse the code, avoids boilerplate code and improves readability.

@jhlegarreta jhlegarreta added the type:enhancement Propose enhancement to the lesson label Mar 20, 2021
@jhlegarreta jhlegarreta requested review from kaitj and josephmje March 20, 2021 18:42
@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Mar 20, 2021

Following the discussion in #69.

Should be possible to reuse it in the tractography notebooks.

@netlify
Copy link

netlify bot commented Mar 20, 2021

Deploy preview for carpentries-dmri ready!

Built with commit d698e2b

https://deploy-preview-76--carpentries-dmri.netlify.app

Put the `fury`camera setup into a function.

Allows to reuse the code, avoids boilerplate code and improves readability.
Copy link
Collaborator

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@jhlegarreta jhlegarreta merged commit 4f55b41 into carpentries-incubator:master Mar 24, 2021
@jhlegarreta jhlegarreta deleted the PutFuryCameraSetupIntoFunction branch March 24, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants