ENH: Add additional local reconstruction model lesson #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitj
requested changes
Nov 3, 2020
There was a problem hiding this comment.
Overall, looks good - made a couple of suggestions in the markdown file, which will probably have to be changed in the notebook as well.
I also noted that the figures look like they were pointing to ../fig/1, but it looks like the screenshots were saved in ../fig/5? I'm just looking at this through git, so I'm not sure if they actually load.
You are right 👍, sorry, my bad. Fixed in 94b3f0e. |
josephmje
reviewed
Nov 4, 2020
Add additional local reconstruction model lesson: add Constrained Spherical Deconvolution (CSD) lesson.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional local reconstruction model lesson: add Constrained Spherical
Deconvolution (CSD) lesson.