ENH: Update deterministic tractography episode #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carpentries-dmri ready! Built with commit 2742802 |
jhlegarreta
approved these changes
Mar 28, 2021
There was a problem hiding this comment.
Have only checked superficially, but looks good.
Thanks for doing this Jason.
It's interesting to see that the we always have an artifact outside the brain volume, as it is the case for the probabilistic tractography episode. Requires further investigation in separate PRs.
|
The deterministic tractography notebook contains the output cell contents in the |
|
Thanks for catching that - I keep forgetting to clear the outputs. Will update and make another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #101 (partially) and #102 Updated the
BIDLayoutcall to make use of the preprocessed data, which it wasn't previously doing. Also added in a couple of figures demonstrating the FA and the resulting tractogram.Took advantage of the commit / PR to remove the solutions notebook which currently wasn't being tested anyways.