Corrected information that Sensor.is_listening is (currently) a method #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
Daraan
changed the title
Daraan
force-pushed
the
fix/sensor-is_listening
branch
from
7ff0929 to
9e653ed
Compare
Daraan
force-pushed
the
fix/sensor-is_listening
branch
from
9e653ed to
594ac5a
Compare
Daraan
added a commit
to Daraan/CARLA-Simulator-Fork-DebianFix
that referenced
this pull request
Jun 14, 2024
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
Daraan
added a commit
to Daraan/CARLA-Simulator-Fork-DebianFix
that referenced
this pull request
Jun 14, 2024
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
Daraan
added a commit
to Daraan/CARLA-Simulator-Fork-DebianFix
that referenced
this pull request
Jul 23, 2024
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
Daraan
added a commit
to Daraan/CARLA-Simulator-Fork-DebianFix
that referenced
this pull request
Jul 29, 2024
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
Daraan
added a commit
to Daraan/CARLA-Simulator-Fork-DebianFix
that referenced
this pull request
Aug 8, 2024
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
Blyron
pushed a commit
that referenced
this pull request
Aug 28, 2024
Was changed to a function in 0.9.15. More info see: #7439
Blyron
added a commit
that referenced
this pull request
Sep 25, 2024
* added cpp client build docs (#7942) * fixed IMU units (#7960) * Update README.md with new TinyURL links (#7988) * Added inverse transform (#7999) Co-authored-by: glopezdiest <[email protected]> * Aaron/fixwheelchair (#8001) * Fix OSM2ODR build * Updated fix wheelchair default value * Docs/unit updates (#8007) * fixed IMU units * updated autitwheel version * Add a `*.pyi` file for auto-completion & hints. To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions. * Fixes and missing Iterators * Fixed Actor.parent Can be None or an Actor * Fixed missing return types * Updated changelog needs merge with dev version * Added DSVEventArray iterator * Added missing type for Labelled Point * Fixed spelling misstakes * Removed wrong unit indication * Added missing -> World to load_world * Added missing return value to reload_world * FIX: __init__ methods do not return * FIX: added ApplyTransform, fixed ApplyTorque * Filled in missing information and types. * ActorList.filter actually returns ActorList * Fixed CityObjectLabels * Disambiguated get_waypoint signature Syntax fix (squased) * Added undocumented variables FutureActor laod_world_if_different * Corrected Sensor.is_listening Was changed to a function in 0.9.15. More info see: #7439 * Added type hints for `values` attribute on enums * Fix intendation shadowing methods * Fix missing @Property * Formatted some docstring to be shorter * Added stubs for HUD drawing Functions from #7168 * Corrected and more precise type-hints - fixed carla.Waypoint.next_until_lane_end * Improved get_waypoint disambiguation correctly added two overload function * Fix spelling mistakes * Better usage of Enum if typing.Self is availiable Using Self will not report an override / incompatible error. * Fix: Enum values were tuples. Added Flag or Int to Enums * Fixes for wrong stubs - OpendriveGenerationParameter had no init - missing @Property - wrong signatures * Added self parameter to property signatures * Various fixes - wrong signatures - wrong names * Added setters for VehicleControl * Improved get_waypoints and Literal type hints * Corrected [try_]spawn_actor keyword name * Added Transform.inverse_transform and corrected signature parameter is called in_point not in_vector * Improved Callable and callbacks signature * Corrections and additions more setters missing, wrong types corrected spelling * Fixed Vector arithmetic * added digital twins video (#8090) * navigation information is now loaded when changing maps * Porting the changes done to UE5 to fix the recording leak to UE4 The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line. * Fixed typo in CityScapes palette (#8137) * Correcting makefile typo to avoid override warning for target "downloadplugins" (#8167) The downloadplugins target is already defined below (line 162). --------- Co-authored-by: MattRoweEAIF <[email protected]> Co-authored-by: glopezdiest <[email protected]> Co-authored-by: glopezdiest <[email protected]> Co-authored-by: Minokori <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: AreopagX <[email protected]> Co-authored-by: Jorge Virgos <[email protected]> Co-authored-by: Sergio Paniego Blanco <[email protected]> Co-authored-by: Ylmdrin <[email protected]>
Blyron
added a commit
that referenced
this pull request
Oct 18, 2024
* added cpp client build docs (#7942) * fixed IMU units (#7960) * Update README.md with new TinyURL links (#7988) * Added inverse transform (#7999) Co-authored-by: glopezdiest <[email protected]> * Aaron/fixwheelchair (#8001) * Fix OSM2ODR build * Updated fix wheelchair default value * Docs/unit updates (#8007) * fixed IMU units * updated autitwheel version * Add a `*.pyi` file for auto-completion & hints. To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions. * Fixes and missing Iterators * Fixed Actor.parent Can be None or an Actor * Fixed missing return types * Updated changelog needs merge with dev version * Added DSVEventArray iterator * Added missing type for Labelled Point * Fixed spelling misstakes * Removed wrong unit indication * Added missing -> World to load_world * Added missing return value to reload_world * FIX: __init__ methods do not return * FIX: added ApplyTransform, fixed ApplyTorque * Filled in missing information and types. * ActorList.filter actually returns ActorList * Fixed CityObjectLabels * Disambiguated get_waypoint signature Syntax fix (squased) * Added undocumented variables FutureActor laod_world_if_different * Corrected Sensor.is_listening Was changed to a function in 0.9.15. More info see: #7439 * Added type hints for `values` attribute on enums * Fix intendation shadowing methods * Fix missing @Property * Formatted some docstring to be shorter * Added stubs for HUD drawing Functions from #7168 * Corrected and more precise type-hints - fixed carla.Waypoint.next_until_lane_end * Improved get_waypoint disambiguation correctly added two overload function * Fix spelling mistakes * Better usage of Enum if typing.Self is availiable Using Self will not report an override / incompatible error. * Fix: Enum values were tuples. Added Flag or Int to Enums * Fixes for wrong stubs - OpendriveGenerationParameter had no init - missing @Property - wrong signatures * Added self parameter to property signatures * Various fixes - wrong signatures - wrong names * Added setters for VehicleControl * Improved get_waypoints and Literal type hints * Corrected [try_]spawn_actor keyword name * Added Transform.inverse_transform and corrected signature parameter is called in_point not in_vector * Improved Callable and callbacks signature * Corrections and additions more setters missing, wrong types corrected spelling * Fixed Vector arithmetic * added digital twins video (#8090) * Typing for GlobalRoutePlanner * 0.9.13+ modernisation of code * made function static * Updated changelog * fixed spelling mistakes * No unnecessary inheritance from object and empty class brackets & other Removed empty variables and whitespaces formatting * navigation information is now loaded when changing maps * Porting the changes done to UE5 to fix the recording leak to UE4 The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line. * Fixed typo in CityScapes palette (#8137) * Correcting makefile typo to avoid override warning for target "downloadplugins" (#8167) The downloadplugins target is already defined below (line 162). * fix typo in title (#8225) * added unreal coord system, fixed v2x (#8251) --------- Co-authored-by: MattRoweEAIF <[email protected]> Co-authored-by: Blyron <[email protected]> Co-authored-by: glopezdiest <[email protected]> Co-authored-by: glopezdiest <[email protected]> Co-authored-by: Blyron <[email protected]> Co-authored-by: Minokori <[email protected]> Co-authored-by: AreopagX <[email protected]> Co-authored-by: Jorge Virgos <[email protected]> Co-authored-by: Sergio Paniego Blanco <[email protected]> Co-authored-by: Ylmdrin <[email protected]>
Blyron
pushed a commit
that referenced
this pull request
Nov 5, 2024
* added cpp client build docs (#7942) * fixed IMU units (#7960) * Update README.md with new TinyURL links (#7988) * Added inverse transform (#7999) Co-authored-by: glopezdiest <[email protected]> * Aaron/fixwheelchair (#8001) * Fix OSM2ODR build * Updated fix wheelchair default value * Docs/unit updates (#8007) * fixed IMU units * updated autitwheel version * Add a `*.pyi` file for auto-completion & hints. To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions. * Fixes and missing Iterators * Fixed Actor.parent Can be None or an Actor * Fixed missing return types * Updated changelog needs merge with dev version * Added DSVEventArray iterator * Added missing type for Labelled Point * Fixed spelling misstakes * Removed wrong unit indication * Added missing -> World to load_world * Added missing return value to reload_world * FIX: __init__ methods do not return * FIX: added ApplyTransform, fixed ApplyTorque * Filled in missing information and types. * ActorList.filter actually returns ActorList * Fixed CityObjectLabels * Disambiguated get_waypoint signature Syntax fix (squased) * Added undocumented variables FutureActor laod_world_if_different * Corrected Sensor.is_listening Was changed to a function in 0.9.15. More info see: #7439 * Added type hints for `values` attribute on enums * Fix intendation shadowing methods * Fix missing @Property * Formatted some docstring to be shorter * Added stubs for HUD drawing Functions from #7168 * Corrected and more precise type-hints - fixed carla.Waypoint.next_until_lane_end * Improved get_waypoint disambiguation correctly added two overload function * Fix spelling mistakes * Better usage of Enum if typing.Self is availiable Using Self will not report an override / incompatible error. * Fix: Enum values were tuples. Added Flag or Int to Enums * Fixes for wrong stubs - OpendriveGenerationParameter had no init - missing @Property - wrong signatures * Added self parameter to property signatures * Various fixes - wrong signatures - wrong names * Added setters for VehicleControl * Improved get_waypoints and Literal type hints * Corrected [try_]spawn_actor keyword name * Added Transform.inverse_transform and corrected signature parameter is called in_point not in_vector * Improved Callable and callbacks signature * Corrections and additions more setters missing, wrong types corrected spelling * Fixed Vector arithmetic * added digital twins video (#8090) * use actor ids for instance segmentation * synchronize bboxes between server and client * add actor_id attribute to bounding boxes * navigation information is now loaded when changing maps * Porting the changes done to UE5 to fix the recording leak to UE4 The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line. * Fixed typo in CityScapes palette (#8137) * Correcting makefile typo to avoid override warning for target "downloadplugins" (#8167) The downloadplugins target is already defined below (line 162). * fix typo in title (#8225) * added unreal coord system, fixed v2x (#8251) --------- Co-authored-by: Minokori <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: Sergio Paniego Blanco <[email protected]> Co-authored-by: Ylmdrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
carla.Sensor.is_listeningis defined twice (since #6013) the <0.9.14 property is overwritten with a method; can also be seen in the DocsThis PR removes the overwritten property and updates the doc, keeping the 0.9.14+ method version in tact.
carla/PythonAPI/carla/source/libcarla/Sensor.cpp
Lines 29 to 31 in f22d49d
Where has this been tested?
Possible Drawbacks
None.
Future work, make it a property again?
I at least would prefer function names like
is_listeningas a property. On one side, it would break the current 0.9.14/15 compatibility, on the other it would restore the one from <0.9.13 which still is found in code more often.So we might want to shift the three Sensor.is_... functions to a property.
This change is