Fail reflink_or_copy if target file already exist #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a controversial take, so I decided to create a separate PR.
The reflink function fails if the target file exists, whereas reflink_or_copy switches to copying. As a result, instead of saving space when possible, the function creates a full copy. I see two solutions for this problem:
This PR implements the first solution, making reflink_or_copy return an error if the target file exists. I also added a few other unrecoverable errors to the list.