Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimization for bin and binstalk #646

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Minor optimization for bin and binstalk #646

merged 6 commits into from
Jan 24, 2023

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Dec 30, 2022 •
edited
Loading

  • Refactor logging: Extract report_err
  • Optimize get_default_pkg_url_template: Return iter instead of Vec
    to avoid heap allocation.
  • Refactor GhCrateMeta::find: Rm launch_baseline_find_tasks
  • Optimize GhCrateMeta::find: Avoid cloning Cow<'_, str>
  • Improve report_err output: Print newline after msg

Signed-off-by: Jiahao XU [email protected]

@NobodyXu
Copy link
Member Author

CI failed due to some bugs on nightly.
I can compile the code without error locally on stable channel.

@NobodyXu NobodyXu mentioned this pull request Dec 31, 2022
Closed
@NobodyXu NobodyXu force-pushed the bin/minor-opt branch 2 times, most recently from 5499772 to df01c13 Compare January 12, 2023 04:53
@NobodyXu NobodyXu marked this pull request as ready for review January 20, 2023 01:38
@NobodyXu NobodyXu requested a review from a team January 20, 2023 01:39
@NobodyXu NobodyXu enabled auto-merge (squash) January 20, 2023 01:40
@NobodyXu NobodyXu requested a review from passcod January 24, 2023 12:48
@NobodyXu NobodyXu merged commit eb95c5b into main Jan 24, 2023
@NobodyXu NobodyXu deleted the bin/minor-opt branch January 24, 2023 12:58
@passcod passcod added the PR: improvement PR that improves existing features or code label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
PR: improvement PR that improves existing features or code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @passcod