Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow batch installation with cli_overrides #454

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Oct 1, 2022

pkg-fmt, bin-dir and pkg-url.

Fixed #444

Signed-off-by: Jiahao XU [email protected]

@NobodyXu NobodyXu marked this pull request as ready for review October 1, 2022 08:19
@NobodyXu NobodyXu enabled auto-merge (squash) October 1, 2022 08:20
@NobodyXu NobodyXu requested a review from passcod October 1, 2022 08:20
@passcod
Copy link
Member

passcod commented Oct 1, 2022

I think there's some help text that says that overrides are not allowed when multiple crates are specified? would need adjusting.

pkg-fmt, bin-dir and pkg-url.

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu force-pushed the feature/batch-installations-with-overrides branch from c1095c4 to db3ea45 Compare October 2, 2022 07:35
@NobodyXu
Copy link
Member Author

NobodyXu commented Oct 2, 2022

I think there's some help text that says that overrides are not allowed when multiple crates are specified? would need adjusting.

FIxed that!

@NobodyXu NobodyXu merged commit dcbe701 into main Oct 2, 2022
@NobodyXu NobodyXu deleted the feature/batch-installations-with-overrides branch October 2, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support batch installation with overrides --pkg-url and --pkg-fmt
2 participants