-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 32 add credits screen #37
base: master
Are you sure you want to change the base?
Issue 32 add credits screen #37
Conversation
Localized strings for ContributorList view
…atar Render UIImage for contributor avatar, or else use placeholder
Removing temporary view controller wiring and an unused import
Hi @christopher-fredregill . Thanks for your contribution! I think the UI should adhere to the current style (black/dark). See the screenshots in the README. I will take a better look at your PR after these changes! Thank you again! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested in comment above
@cardoso is this where the gear button should go? |
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 70.2% 66.19% -4.01%
==========================================
Files 13 17 +4
Lines 443 494 +51
==========================================
+ Hits 311 327 +16
- Misses 132 167 +35
Continue to review full report at Codecov.
|
@christopher-fredregill yes! Sorry for the late response |
Manage this branch in SquashTest this branch here: https://issue-32-add-credits-screen-r73y9.squash.io |
@cardoso care to take a look? Not sure if this is exactly what you had in mind, but I tried to adhere to the requirements you laid out in #32 .
Also, not sure how you'd like this screen to be accessed from within the app. I temporarily added this line in
AppDelegate.swift
just to toy around with it locally:window?.rootViewController = ContributorListController(rootView: ContributorList())
Here are some sample screenshots:
![Simulator Screen Shot - iPhone 11 - ContributorList View](https://user-images.githubusercontent.com/16979231/66726611-4ad5c100-edef-11e9-9055-5ba087c32a26.png)
![Simulator Screen Shot - iPhone 11 - ContributorProfile View](https://user-images.githubusercontent.com/16979231/66726610-490bfd80-edef-11e9-857b-a0fa708aa415.png)
Thanks!