Store session keys and node info in local storage #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to survive random refreshes and we can invalidate session keys on-demand.
ch1bo
force-pushed
the
local-storage
branch
2 times, most recently
from
98ad252 to
8fc9224
Compare
This allows us to easily flip the persistent storage feature on and off easily.
ch1bo
commented
Jul 25, 2024
| let privateKey = window.localStorage.getItem("hydra-doom-session-key"); | ||
| if (privateKey == null) { | ||
| if (persistentSession && privateKey == null) { |
There was a problem hiding this comment.
@Quantumplation There is another place where localstorage is used. I'll set it also below.
Or should we maybe use a .env var to only enable this in DEVELOPMENT or so?
There was a problem hiding this comment.
Made it fully optional with: 5a12385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to survive random refreshes and we can invalidate session
keys on-demand using a button or so.