Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated install to pyproject.toml #324

Merged
merged 19 commits into from
Jan 31, 2024
Merged

Updated install to pyproject.toml #324

merged 19 commits into from
Jan 31, 2024

Conversation

norlandrhagen
Copy link
Contributor

cc @maxrjones I updated the install to try to only use pyproject.toml. Hopefully this can fix the broken install issue.

#322

@maxrjones
Copy link
Contributor

@norlandrhagen I think a lot of the pre-commit errors are because pyproject.toml is configured for ruff but .pre-commit-config.yaml still has flake8. It's probably worth updating to:

ci:
  autoupdate_schedule: quarterly
  autofix_prs: false

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.4.0
    hooks:
      - id: trailing-whitespace
      - id: end-of-file-fixer
      - id: check-docstring-first
      - id: check-json
      - id: check-yaml
      - id: debug-statements
      - id: mixed-line-ending

  - repo: https://github.com/asottile/pyupgrade
    rev: v3.14.0
    hooks:
      - id: pyupgrade
        args:
          - '--py38-plus'

  - repo: https://github.com/psf/black
    rev: 23.9.1
    hooks:
      - id: black
      - id: black-jupyter

  - repo: https://github.com/keewis/blackdoc
    rev: v0.3.8
    hooks:
      - id: blackdoc

  - repo: https://github.com/astral-sh/ruff-pre-commit
    rev: 'v0.0.276'
    hooks:
      - id: ruff
        args: ['--fix']

  - repo: https://github.com/pre-commit/mirrors-prettier
    rev: v3.0.0-alpha.9-for-vscode
    hooks:
      - id: prettier

Copy link
Contributor

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @norlandrhagen!!

@norlandrhagen norlandrhagen merged commit 0d8508c into main Jan 31, 2024
4 checks passed
@norlandrhagen norlandrhagen deleted the update_pyproj branch January 31, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants