Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling sass in benefit of sassc #74

Conversation

paulocastro-toptal
Copy link

First of all, thank you guys for sharing it!

I just created a new project using raygun and when tried to run:

rails generate controller <controller_name>

I got an error: "sass not found"

In order to Rails use sassc it was need to disable saas

@christiannelson
Copy link
Contributor

@paulocastro-toptal Great find!

I wonder if there's a way to confirm that sassc is being used to generate css, since both gems are technically present in the bundle.

@paulocastro-toptal
Copy link
Author

this https://github.com/sass/sassc-rails/blob/master/lib/sassc-rails.rb#L3
and this https://github.com/sass/sassc-rails/blob/master/lib/sassc/rails/railtie.rb#L59-L60
should enforce the use of it

but, to be honest, I was not able to find a way to be 100% sure of it, other than the performance itself.
maybe a tweak on sassc-rails gem could be proposed to include a way of explicit show if sassc was used.

@christiannelson
Copy link
Contributor

Opened sass/sassc-rails#74 to see if there's a reasonable way to make this work without the other gem.

@paulocastro-toptal
Copy link
Author

Hi Christian
I saw you message on sassc-rails. Your idea is to do something like slim-railsdoes? (Injecting a custom generator during the scaffolding executing)
If so, I'll be happy on help with that.. it would be a good opportunity to learn how to create custom generators.

@christiannelson
Copy link
Contributor

christiannelson commented Aug 3, 2016

@paulocastro-toptal Yeah. I took a quick look at what's in the sass-rails gem and it's a handful of small files. The easiest thing would be to simply duplicate what is done there. That's one of my least favorite things to do, but those files haven't been changed in about 2 years and the templates is extremely minimal (i.e. not likely to change much).

I'm on vacation now and probably won't look at for a few weeks. If you're inspired, go for it. :)

@christiannelson
Copy link
Contributor

Fixed in 36cb811. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants