test: add conprehensive integration test #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @julienbrs kindly review |
julienbrs
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Good work on setting this up @martinvibes! However, you should add some assertions at the end of each test to validate the expected outcomes. For example:
- Compare Merkle tree root hashes with precomputed expected values.
- Validate the correctness of generated proofs, potentially by reconstructing and verifying the root hash.
- Ensure merged trees' root hashes and allocation integrity are explicitly tested.
These assertions will ensure the tests not only run successfully but also verify that the outputs match the expected results.
|
hey @julienbrs kindly review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @julienbrs kindly review #4
added Comprehensive Integration Tests