More etiquette for responding to code reviews #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerc
requested changes
Sep 13, 2022
chandlerc
approved these changes
Sep 13, 2022
docs/project/code_review.md
Outdated
Comment on lines
262
to
263
| for re-review. | ||
|
|
There was a problem hiding this comment.
Maybe also suggest flagging the reviewer to re-review using the "request review" refresh-looking button illustrated here:
There was a problem hiding this comment.
Added, with some text.
chandlerc
approved these changes
Sep 13, 2022
Co-authored-by: Chandler Carruth <[email protected]>
chandlerc
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the advice from #2022 (comment)