feat(web-components): adds FullPageError to web components #6910
+2,738
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMelox
requested review from
devadula-nandan and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6910 +/- ##
==========================================
+ Coverage 81.51% 81.56% +0.04%
==========================================
Files 399 403 +4
Lines 12975 13050 +75
Branches 4268 4297 +29
==========================================
+ Hits 10577 10644 +67
- Misses 2398 2406 +8
|
| description="The page you requested has moved or is unavailable, or the specified URL is not valid. Please check the URL or search the site for the requested content." | ||
| kind="404" | ||
| > | ||
| <!-- Pass any content you want to didplay to the user here --> |
There was a problem hiding this comment.
Suggested change
| <!-- Pass any content you want to didplay to the user here --> | |
| <!-- Pass any content you want to display to the user here --> |
devadula-nandan
requested changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6778
This PR adds FullPageError as a web components