refactor: decouple framer motion and use native css for animation #6876
+209
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amal-k-joy
requested review from
elycheea and
makafsal
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6876 +/- ##
==========================================
- Coverage 81.51% 81.33% -0.18%
==========================================
Files 399 399
Lines 12975 12985 +10
Branches 4268 4283 +15
==========================================
- Hits 10576 10561 -15
- Misses 2399 2424 +25
|
|
There are some subtleties to the filter panel animation that still need to be transferred over. The two major pieces that seem to be missing are the actions transitioning up after the panel animation is complete and the table snaps to it's new placement rather than a gradual transition from it's before panel position. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6760
Remove framer motion and use native css animations
Fixed an issue issue in side panel related to reduced motion
refer side panel original issue for reference
How did you test and verify your work?
local storybook