feat(Web Components): create About Modal component in Web components #6874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6874 +/- ##
==========================================
+ Coverage 81.53% 81.54% +0.01%
==========================================
Files 400 400
Lines 13000 13000
Branches 4280 4280
==========================================
+ Hits 10599 10601 +2
+ Misses 2401 2399 -2
|
sangeethababu9223
requested review from
davidmenendez and
matthewgallo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6814, #6812 & 6875
Create About Modal component in Web Components
What did you change?
Created a new component
About Modalin Web components package.the following are done:
Note: In the React version,
ComposedModalfrom Core is used. But in the Web Components package, there's no ComposedModal, onlyModal. Also, Modal doesn’t use the CarbonTooltipcomponent—it just uses thetitleattribute directly on the close button. The same applies toAboutModalsince it also uses Modal for its implementation.How did you test and verify your work?
Storybook