Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NotificationsPanel): remove hard-coded dark theme #6862

Conversation

paul-balchin-ibm
Copy link
Contributor

@paul-balchin-ibm paul-balchin-ibm commented Feb 7, 2025

Closes #5259

NotificationsPanel now inherits from parent theme.

What did you change?

packages/ibm-products-styles/src/components/NotificationsPanel/_notifications-panel.scss

How did you test and verify your work?

  • Storybook

Themed output

The first notification in each screenshot shows the hover state when the mouse is over the close ("X") button.

white g10 g90 g100
image image image image

Empty state

white g10 g90 g100
image image image image

@paul-balchin-ibm paul-balchin-ibm self-assigned this Feb 7, 2025
@paul-balchin-ibm paul-balchin-ibm requested a review from a team as a code owner February 7, 2025 16:27
@paul-balchin-ibm paul-balchin-ibm requested review from davidmenendez and matthewgallo and removed request for a team February 7, 2025 16:27
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit dda8463
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67aca728c981c8000897dc23
😎 Deploy Preview https://deploy-preview-6862--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit dda8463
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67aca72831538600087adf65
😎 Deploy Preview https://deploy-preview-6862--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (f7609f5) to head (dda8463).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6862   +/-   ##
=======================================
  Coverage   81.51%   81.52%           
=======================================
  Files         399      399           
  Lines       12977    12978    +1     
  Branches     4277     4278    +1     
=======================================
+ Hits        10578    10580    +2     
+ Misses       2399     2398    -1     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@paul-balchin-ibm paul-balchin-ibm added the needs: design opinion Design question needs opinion from designer label Feb 7, 2025
@elycheea elycheea requested a review from a team February 7, 2025 16:52
@elycheea
Copy link
Contributor

Noticed some small things when I was posting to the team channel for design review —

  1. Missing borders on the panel (compare to the switcher). Probably also should still have a shadow since it’s a floating element?
  2. Empty state theme! Looks like the theme is hardcoded here — might need to do a some theme detection so that it switches between light/dark since empty state component used here relies on the theme prop.

image

@paul-balchin-ibm
Copy link
Contributor Author

Great catches: added borders, drop shadow, and a themed empty state illustration.

davidmenendez
davidmenendez previously approved these changes Feb 11, 2025
@devadula-nandan devadula-nandan self-requested a review February 12, 2025 13:15
Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paul-balchin-ibm,

there are few token suggestions. added the comments.
rest looks good to me.

@devadula-nandan devadula-nandan self-requested a review February 12, 2025 13:58
@paul-balchin-ibm paul-balchin-ibm added this pull request to the merge queue Feb 12, 2025
Merged via the queue into carbon-design-system:main with commit 64d9b48 Feb 12, 2025
32 checks passed
@paul-balchin-ibm paul-balchin-ibm deleted the 5259_notifications-panel--themed branch February 12, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NotificationsPanel needs: design opinion Design question needs opinion from designer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotificationsPanel does not honor carbon theme
4 participants