-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NotificationsPanel): remove hard-coded dark theme #6862
fix(NotificationsPanel): remove hard-coded dark theme #6862
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6862 +/- ##
=======================================
Coverage 81.51% 81.52%
=======================================
Files 399 399
Lines 12977 12978 +1
Branches 4277 4278 +1
=======================================
+ Hits 10578 10580 +2
+ Misses 2399 2398 -1
|
Noticed some small things when I was posting to the team channel for design review —
|
Great catches: added borders, drop shadow, and a themed empty state illustration. |
packages/ibm-products-styles/src/components/NotificationsPanel/_notifications-panel.scss
Show resolved
Hide resolved
packages/ibm-products-styles/src/components/NotificationsPanel/_notifications-panel.scss
Show resolved
Hide resolved
packages/ibm-products-styles/src/components/NotificationsPanel/_notifications-panel.scss
Outdated
Show resolved
Hide resolved
packages/ibm-products-styles/src/components/NotificationsPanel/_notifications-panel.scss
Show resolved
Hide resolved
packages/ibm-products-styles/src/components/NotificationsPanel/_notifications-panel.scss
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are few token suggestions. added the comments.
rest looks good to me.
64d9b48
Closes #5259
NotificationsPanel now inherits from parent theme.
What did you change?
How did you test and verify your work?
Themed output
The first notification in each screenshot shows the hover state when the mouse is over the close ("X") button.
white
g10
g90
g100
Empty state
white
g10
g90
g100