fix(actions): process pr review action, remove setup-node
#6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewgallo
requested review from
elycheea,
kennylam and
a team
as code owners
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6559 +/- ##
==========================================
- Coverage 79.97% 79.96% -0.01%
==========================================
Files 394 394
Lines 12894 12894
Branches 4273 4273
==========================================
- Hits 10312 10311 -1
- Misses 2582 2583 +1
|
davidmenendez
approved these changes
Dec 9, 2024
matthewgallo
changed the title
setup-node
elycheea
approved these changes
Dec 10, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 10, 2024
5ceeaa5
38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another bug I found in the PR review label action. Because we include
setup-nodeand specify acacheconfiguration, thePost Setup Node.jsjob fails because it's looking for a.yarn/cachedirectory, however since this action doesn't depend on any dependencies being installed thecachedirectory doesn't exist. I think it's safe for us to just remove thesetup-nodestep.Example of failing job
Good news is that the action looks to be working now, outside of this one issue!
What did you change?
How did you test and verify your work?
Manually verified in the action that we don't need to install dependencies, it's all based on results from various GH api requests.