Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(code-snippet): merge templated-based demo html code #774

Closed
wants to merge 1 commit into from
Closed

chore(code-snippet): merge templated-based demo html code #774

wants to merge 1 commit into from

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented May 16, 2018

Added

  • Support for different Handlebars template for specific component variants

Changed

  • Fix for code snippet demo due to merging it with templated-based demo html code

Testing / Reviewing

Testing should make sure no component demo is broken, especially code snippet.

@asudoh
chore(code-snippet): merge templated-based demo html code
aaccb2f 
This change also adds different Handlebars template for specific component variants.
@asudoh asudoh requested a review from alisonjoseph May 16, 2018 01:40
alisonjoseph
alisonjoseph approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asudoh asudoh mentioned this pull request May 17, 2018
Merged
@alisonjoseph
Copy link
Member

alisonjoseph commented May 17, 2018 •
edited
Loading

closing this, changes captured in #779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asudoh @alisonjoseph