fix(tabs): revert input background changes #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
approved these changes
Apr 22, 2020
|
@tw15egan should we include this as a hotfix in a 10.11.2 release? |
|
@joshblack yeah would make sense to get this out ASAP |
|
Deploy preview for carbon-elements ready! Built with commit ff726d9 |
|
Deploy preview for carbon-components-react ready! Built with commit ff726d9 https://deploy-preview-5914--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 04262fc |
|
Deploy preview for carbon-elements ready! Built with commit 5b18b78 |
|
Deploy preview for carbon-components-react ready! Built with commit 04262fc https://deploy-preview-5914--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit 5b18b78 https://deploy-preview-5914--carbon-components-react.netlify.app |
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Apr 23, 2020
Co-authored-by: Josh Black <[email protected]>
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Apr 23, 2020
Co-authored-by: Josh Black <[email protected]>
joshblack
added a commit
that referenced
this pull request
Apr 23, 2020
Co-authored-by: Josh Black <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5598
Based on a conversation in Slack, these changes were causing unintended consequences. We'll have to postpone this until v11 and also make sure we target inputs that are using the
lightprop.https://ibm-studios.slack.com/archives/C046Y0YUD/p1587564854319500
Changelog
Changed
lightprop to achieve the same effectRemoved
field-02Testing / Reviewing
Verify nothing is broken