-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): stop passing selectionMode through as a prop #5908
fix(react): stop passing selectionMode through as a prop #5908
Conversation
Incidentally, while following the contribution instructions, I found that
Any clue what causes this? |
Deploy preview for carbon-elements ready! Built with commit cd2a7e4 |
Deploy preview for carbon-components-react ready! Built with commit cd2a7e4 https://deploy-preview-5908--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. I'm able to replicate the EMFILE build failure only on Windows, and I think we can open that as a separate issue
…gn-system#5908) Co-authored-by: Josh Black <[email protected]>
…gn-system#5908) Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Closes #5903.
In
<ContentSwitcher>
and<Tabs>
, theselectionMode
is no longer passed as a prop to the inner<div>
.Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}
Unit tests have been added to demonstrate this issue. Reviewers can also view these components in Storybook and see that the errors in question have gone away. However, you might consider altering your unit testing so that all errors of this kind cause a failure automatically.