chore: force https in react storybook deployment #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 0f6c797 https://deploy-preview-5078--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 0f6c797 |
|
Deploy preview for carbon-components-react failed. Built with commit 0f6c797 https://app.netlify.com/sites/carbon-components-react/deploys/5e22546d710552000b50b6a2 |
joshblack
approved these changes
Jan 17, 2020
|
@vpicone |
|
@joshblack you could also deploy to a new cf app to make sure the option is working as intended. |
asudoh
approved these changes
Jan 18, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Jan 23, 2020
…m#5078) Co-authored-by: Josh Black <[email protected]> Co-authored-by: Akira Sudoh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
carbondesignsystem.comssl cert now uses a wildcard. We should force the react storybook to leveragehttpsand avoid the "Connection not secure" notices from browsers.